Refactor default config location resolution to use pathlib instead of os #2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-pczajka
added
the
DO_NOT_PORT_CHANGES_TO_SP
sfc-gh-pczajka
changed the title
sfc-gh-aling
reviewed
Aug 7, 2024
Comment on lines
-34
to
-37
| snowflake_home = os.path.expanduser( | ||
| snowflake_home = pathlib.Path( | ||
| os.environ.get("SNOWFLAKE_HOME", "~/.snowflake/"), | ||
| ) | ||
| if os.path.exists(snowflake_home): |
There was a problem hiding this comment.
I'm just curious is there a bug related to the previous implementation?
I checked the code on windows and think they are effectively equivalent, backslash will be handled by the path.Pathlib called in SFPlatformDirs constructor.
or it's more about code improvement?
import os
import pathlib
assert pathlib.Path(os.path.expanduser("~/.snowflake/")) == pathlib.Path(str(pathlib.Path("~/.snowflake/").expanduser()))There was a problem hiding this comment.
Ahhh, I see - I didn't notice that this is handled via pathlib later on. I think this might be worth adding anyway, as the code becomes less confusing (I honestly thought that there was a bug in there), although the connector works properly.
I've updated the PR title and description.md
sfc-gh-pczajka
changed the title
sfc-gh-aling
approved these changes
Aug 8, 2024
sfc-gh-pczajka
deleted the
SNOW-1616595-fix-default-config-location-on-Windows
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #2018
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Use
pathlibinstead ofosto resolve default config file paths(Optional) PR for stored-proc connector: